vendor.conf: Pin containernetworking/plugins to 1fb94a42 #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'd guess the test failures are flakes? I don't see how changing the |
Member
|
bot, retest this please |
Collaborator
|
☔ The latest upstream changes (presumably a160857) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Tests are green, but you picked up a merge conflict |
containernetworking/plugins@a0eac8d7 (pkg/ns: remove namespace creation, 2018-03-16) removed NewNS, which we use in libpod/networking.go. Pinning to the previous commit, containernetworking/plugins@1fb94a42 (Merge pull request containers#96 from DennisDenuto/denuto/master, 2018-03-14), allows us to run vndr without breaking our build. This is a short term fix; moving forward we'll want to either drop this dependency or catch up with the new upstream API. The upstream package seems to have been fairly stable in the meantime, because even with the new pinned version, a vndr re-vendor generates no changes: $ vndr github.com/containernetworking/plugins Signed-off-by: W. Trevor King <[email protected]>
Contributor
Author
|
Rebased. |
Member
|
LGTM |
Collaborator
|
📌 Commit 49d597f has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containernetworking/plugins@a0eac8d7 (pkg/ns: remove namespace creation, 2018-03-16) removed
NewNS, which we use inlibpod/networking.go. Pinning to the previous commit, containernetworking/plugins@1fb94a42 (Merge pull request #96 from DennisDenuto/denuto/master, 2018-03-14), allows us to runvndrwithout breaking our build. This is a short term fix; moving forward we'll want to either drop this dependency or catch up with the new upstream API.The upstream package seems to have been fairly stable in the meantime, because even with the new pinned version, a
vndrre-vendor generates no changes:$ vndr github.com/containernetworking/pluginsSpun off from #747.